Pin GitHub Actions to SHAs [SRE-1802]#8
Draft
tylergohl wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Supply-chain hardening update to make GitHub Actions workflow dependencies immutable by pinning external actions to specific commit SHAs.
Changes:
- Pinned
actions/checkoutto a commit SHA in both PR and release workflows (with the prior major version retained as a comment). - Pinned
docker/login-actionanddocker/setup-qemu-actionto commit SHAs in the release workflow.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/pr.yaml | Pins actions/checkout to an immutable commit SHA for PR CI runs. |
| .github/workflows/main.yaml | Pins actions/checkout, docker/login-action, and docker/setup-qemu-action to immutable commit SHAs for tag/release builds. |
Comments suppressed due to low confidence (1)
.github/workflows/main.yaml:30
run:is defined as a YAML mapping here (because it has no scalar value) rather than a string, which GitHub Actions expects for a steprun. This will cause the workflow to fail to parse/execute. Userun: <command>on the same line, orrun: |and indent the command(s) under it.
- name: Build/Push to GitHub Container Registry
run:
make push-multiarch PULL_BASE_REF=$(git describe --tags --abbrev=0) REGISTRY_NAME=ghcr.io/ctrliq BUILD_PLATFORMS="linux amd64 amd64 -amd64; linux arm64 arm64 -arm64"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin GitHub Actions references in this repo to immutable commit SHAs (with the original tag/branch preserved in a trailing comment). Part of SRE-1802 — org-wide supply-chain hardening.
Scope
This PR pins:
ctrliq/*reusable workflow and action referencesNo actions in this repo were claimed by clo-ciq's effort — this PR pins everything.
Files touched
.github/workflows/main.yaml.github/workflows/pr.yamlTest plan
sha_pinning_requiredcan be enabled on it